Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for memo backend. #172

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

mnottale
Copy link

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "memo-backend" [email protected]:infinit/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@Dimrok
Copy link

Dimrok commented Jul 27, 2017

Hi @mnottale.

Could you add some tests, like the other backends please (e.g. zookeeper_test, etcd_test, etc.).

@Dimrok
Copy link

Dimrok commented Aug 17, 2017

Hi @mnottale.

seems good but could you create different PRs for each separate problems you fixed, because:

Matthieu Nottale added 7 commits August 21, 2017 11:52
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants